Messages in this thread | | | From | Vineet Gupta <> | Subject | Re: [PATCH] ARC: Remove ISS_SMP_EXTN entirely | Date | Tue, 8 Apr 2014 10:49:05 +0000 |
| |
On Tuesday 08 April 2014 04:12 PM, Paul Bolle wrote: > Vineet, > > On Tue, 2014-04-08 at 09:18 +0000, Vineet Gupta wrote: >> There's obvious bitrot here - however this code is not dead yet ! >> I have a unpushed fix which uses this Kconfig item. >> >> diff --git a/arch/arc/plat-arcfpga/Makefile b/arch/arc/plat-arcfpga/Makefile >> index a44e22ebc1b7..4d1bddc34b5b 100644 >> --- a/arch/arc/plat-arcfpga/Makefile >> +++ b/arch/arc/plat-arcfpga/Makefile >> @@ -9,4 +9,4 @@ >> KBUILD_CFLAGS += -Iarch/arc/plat-arcfpga/include >> >> obj-y := platform.o irq.o >> -obj-$(CONFIG_SMP) += smp.o >> +obj-$(CONFIG_ISS_SMP_EXTN) += smp.o > I just realized that this means you're only using ISS_SMP_EXTN as an > alias for SMP, aren't you? Ie, smp.o will now be built if both > ARC_PLAT_FPGA_LEGACY and SMP are set. That will not change by this > patch. > > So unless you're planning to do something else too if ISS_SMP_EXTN is > set there seems to be little value in using this symbol like that.
Indeed so - I just sent u one hunk to give an idea. There's other code too where CONFIG_SMP will be replaced by CONFIG_ISS_SMP_EXTN as I'm decoupling SMP support from this SMP extension.
I'll push a patch later today - which will hopefully hit mainline within this merge window - if not in one of the rcs.
-Vineet
| |