Messages in this thread Patch in this message | | | Subject | Re: [PATCH] ARC: Remove ISS_SMP_EXTN entirely | From | Paul Bolle <> | Date | Tue, 08 Apr 2014 12:42:23 +0200 |
| |
Vineet,
On Tue, 2014-04-08 at 09:18 +0000, Vineet Gupta wrote: > There's obvious bitrot here - however this code is not dead yet ! > I have a unpushed fix which uses this Kconfig item. > > diff --git a/arch/arc/plat-arcfpga/Makefile b/arch/arc/plat-arcfpga/Makefile > index a44e22ebc1b7..4d1bddc34b5b 100644 > --- a/arch/arc/plat-arcfpga/Makefile > +++ b/arch/arc/plat-arcfpga/Makefile > @@ -9,4 +9,4 @@ > KBUILD_CFLAGS += -Iarch/arc/plat-arcfpga/include > > obj-y := platform.o irq.o > -obj-$(CONFIG_SMP) += smp.o > +obj-$(CONFIG_ISS_SMP_EXTN) += smp.o
I just realized that this means you're only using ISS_SMP_EXTN as an alias for SMP, aren't you? Ie, smp.o will now be built if both ARC_PLAT_FPGA_LEGACY and SMP are set. That will not change by this patch.
So unless you're planning to do something else too if ISS_SMP_EXTN is set there seems to be little value in using this symbol like that.
Paul Bolle
| |