Messages in this thread | | | Subject | Re: [PATCH v2 4/5] Staging: rts5139: pr_warn(...) in place of printk(KERN_WARNING ...) | From | Joe Perches <> | Date | Mon, 07 Apr 2014 15:03:26 -0700 |
| |
On Mon, 2014-04-07 at 13:56 -0700, Greg KH wrote: > On Mon, Apr 07, 2014 at 01:34:47PM -0700, Joe Perches wrote: > > On Mon, 2014-04-07 at 22:27 +0200, Fabio Falzoi wrote: > > > All printk(KERN_WARNING ...) replaced with pr_warn(...). > > > > Please remove the RTS51X_TIP prefix and and and use > > > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > > > before any #include so that pr_<level> uses > > are prefixed in a standard way. > > > Feel free to do this as a follow-on patch, I'll take this one as-is, as > it is better than what we have currently...
<shrug>
Seeing as how you're not applying staging patches until after -rc1 is out, I don't see the harm in asking the submitter to fix whatever issues exist in a patch set before that.
| |