lkml.org 
[lkml]   [2014]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC/PATCH] mtd: ubi: Fix ubi free PEBs count calculation
From
On Tue, Apr 1, 2014 at 10:02 AM, Tanya Brokhman <tlinder@codeaurora.org> wrote:
> The ubi->free_count should be updated with every insert/remove to/from
> the ubi->free list.
>
> Signed-off-by: Tanya Brokhman <tlinder@codeaurora.org>
>
> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> index 9a36f78..ca74d19 100644
> --- a/drivers/mtd/ubi/wl.c
> +++ b/drivers/mtd/ubi/wl.c
> @@ -690,6 +690,8 @@ static struct ubi_wl_entry *get_peb_for_wl(struct ubi_device *ubi)
>
> e = find_wl_entry(ubi, &ubi->free, WL_FREE_MAX_DIFF);
> self_check_in_wl_tree(ubi, e, &ubi->free);
> + ubi->free_count--;
> + ubi_assert(ubi->free_count >= 0);
> rb_erase(&e->u.rb, &ubi->free);
>
> return e;
> @@ -1090,6 +1092,7 @@ static int wear_leveling_worker(struct ubi_device *ubi, struct ubi_work *wrk,
>
> /* Give the unused PEB back */
> wl_tree_add(e2, &ubi->free);
> + ubi->free_count++;
> goto out_cancel;
> }
> self_check_in_wl_tree(ubi, e1, &ubi->used);
> --

Acked-by: Richard Weinberger <richard@nod.at>

--
Thanks,
//richard


\
 
 \ /
  Last update: 2014-04-07 16:01    [W:0.057 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site