Messages in this thread | | | Date | Mon, 7 Apr 2014 14:17:24 +0200 | From | Mike Looijmans <> | Subject | Re: [PATCH v2 2/5] ARM: zynq: dt: Convert to preprocessor includes |
| |
On 04/07/2014 07:58 AM, Michal Simek wrote: > Hi Soren, > > On 04/05/2014 01:14 AM, Soren Brinkmann wrote: >> Convert all Zynq DT files to the dtc preprocessor include syntax. >> This allows to include header files in the devicetrees like other >> SoC-types already do. >> >> Inspired-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> >> (http://www.spinics.net/lists/arm-kernel/msg319832.html) >> >> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > > These 4 patches needs more wider discussion if this is helpful or > not. Currently I can't see any value in it because everything > is just generated and fixed. I think I had the same discussion > with Laurent some weeks ago regarding this.
I would be kinda neutral here. I'd consider it helpful, it improves readability (regardless of whether they are generated or hand crafted). That's convenient for things like interrupt sensitivity, I can't remember whether 4 is level or edge type. On the other hand, the clock indices are just as much magic numbers as the memory addresses. If I suspect an error in that area, I'd start by lokking in /sys/kernel/debug/clk but wouldn't start in the DT.
> IRC the origin idea to use this was especially for people who > writing these DTS by hand which is not our case - at least > for majority of our customers.
I write them by hand. Is there any other way?
Mike.
Met vriendelijke groet / kind regards,
Mike Looijmans
TOPIC Embedded Systems Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best Telefoon: (+31) (0) 499 33 69 79 Telefax: (+31) (0) 499 33 69 70 E-mail: mike.looijmans@topic.nl Website: www.topic.nl
Please consider the environment before printing this e-mail
Visit us at the Hannover Messe 7 - 11 April 2014 - Hall 002/D10 (Dutch Pavillion) http://www.hannovermesse.de/exhibitor/topic-embedded-products/V229623
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |