Messages in this thread | | | Date | Sun, 6 Apr 2014 11:28:56 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] Staging: rtl8192e: Fix sparse warning |
| |
On Sun, Apr 06, 2014 at 01:23:15PM -0500, Joel Pelaez Jorge wrote: > drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: > symbol 'r8192_wx_handlers_def' was not declared. Should it be static > > Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com> > --- > drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > index 498995d..5baa699 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c > @@ -20,6 +20,8 @@ > #include <linux/string.h> > #include "rtl_core.h" > > +extern struct iw_handler_def r8192_wx_handlers_def;
Don't put "extern" in a .c file, that's never the correct solution.
thanks,
greg k-h
| |