[lkml]   [2014]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH -mm 0/3] slab: cleanup mem hotplug synchronization

kmem_cache_{create,destroy,shrink} need to get a stable value of
cpu/node online mask, because they init/destroy/access per-cpu/node
kmem_cache parts, which can be allocated or destroyed on cpu/mem
hotplug. To protect against cpu hotplug, these functions use
{get,put}_online_cpus. However, they do nothing to synchronize with
memory hotplug - taking the slab_mutex does not eliminate the
possibility of race as described in patch 3.

What we need there is something like get_online_cpus, but for memory. We
already have lock_memory_hotplug, which serves for the purpose, but it's
a bit of a hammer right now, because it's backed by a mutex. As a
result, it imposes some limitations to locking order, which are not
desirable, and can't be used just like get_online_cpus. I propose to
turn this mutex into an rw semaphore, which will be taken for reading in
lock_memory_hotplug and for writing in memory hotplug code (that's what
patch 1 does).

When I tried to use this rw semaphore in the slab implementation, I came
across a problem with lockdep: rw_semaphore is not marked as read
recursive although it is (at least, it looks so to me), so lockdep
complains about wrong ordering with a sysfs internal mutex in case of
slub, because in contrast to recursive read lock, non-recursive one
should always be taken in the same order with a mutex. That's why in
patch 2 I mark rw semaphore as read-recursive, just like rw spin lock.


Vladimir Davydov (3):
mem-hotplug: turn mem_hotplug_mutex to rwsem
lockdep: mark rwsem_acquire_read as recursive
slab: lock_memory_hotplug for kmem_cache_{create,destroy,shrink}

include/linux/lockdep.h | 2 +-
include/linux/mmzone.h | 7 ++---
mm/memory_hotplug.c | 70 +++++++++++++++++++++--------------------------
mm/slab.c | 26 ++----------------
mm/slab.h | 1 +
mm/slab_common.c | 35 ++++++++++++++++++++++--
mm/slob.c | 3 +-
mm/slub.c | 5 ++--
mm/vmscan.c | 2 +-
9 files changed, 75 insertions(+), 76 deletions(-)


 \ /
  Last update: 2014-04-06 18:01    [W:0.064 / U:2.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site