lkml.org 
[lkml]   [2014]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: linux-next: Tree for Apr 1 (netfilter)
From
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun, 6 Apr 2014 15:50:04 +0200

> On Tue, Apr 1, 2014 at 9:22 PM, David Miller <davem@davemloft.net> wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>> Date: Tue, 01 Apr 2014 11:34:15 -0700
>>
>>> on x86_64:
>>>
>>> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
>>> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
>>>
>>> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).
>>
>> I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
>> sized array elements.
>
> Anyone with a suggestion?
>
> Please note this is now in Linus' tree, possibly crashing people's boxes...

I took in the version of the fix I didn't like via Pablo for
now.


\
 
 \ /
  Last update: 2014-04-06 18:01    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog