Messages in this thread Patch in this message | | | Date | Sun, 6 Apr 2014 00:36:49 +0200 | From | Christian Engelmayer <> | Subject | [PATCH] modpost: Fix ressource leak in read_dump() |
| |
Function read_dump() memory maps the input via grab_file(), but fails to call the corresponding unmap function. Add the missing call to release_file(). Detected by Coverity: CID 1192419
Signed-off-by: Christian Engelmayer <cengelma@gmx.at> --- Compile tested - Applies against v3.14 as well as linux-next. --- scripts/mod/modpost.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 0663556..ea3e2bd 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2113,8 +2113,10 @@ static void read_dump(const char *fname, unsigned int kernel) s->preloaded = 1; sym_update_crc(symname, mod, crc, export_no(export)); } + release_file(file, size); return; fail: + release_file(file, size); fatal("parse error in symbol dump file\n"); } -- 1.8.3.2[unhandled content-type:application/pgp-signature] | |