lkml.org 
[lkml]   [2014]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/9] crypto: qce: Add register defines
    Hi Srini,

    Thanks for the comments.

    On 04/04/2014 12:23 PM, Srinivas Kandagatla wrote:
    >
    > Minor nitpicks.
    >
    > On 03/04/14 17:17, Stanimir Varbanov wrote:
    >> +#define REQ_SIZE 17 /* bit 20-17 */
    >
    > I would have defined macros like this with _SHIFT at the end, something
    > like this:
    >
    > #define REQ_SIZE_SHIFT 17

    sure, I will add _SHIFT suffix to all places where it is applicable.

    >
    >> +#define REQ_SIZE_MASK (0xf << REQ_SIZE)
    > You could possibly use GENMASK macro for this, its much readable, in
    > *some cases* it could reduce few more lines in header too.
    >
    > #define REQ_SIZE_MASK GENMASK(20, 17)
    >
    >
    > My comments are equally applicable to most macros in this header file.

    yes, right will do. Thanks.

    regards,
    Stan


    \
     
     \ /
      Last update: 2014-04-05 03:41    [W:4.159 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site