Messages in this thread | | | Date | Fri, 4 Apr 2014 11:42:51 -0700 | Subject | Re: [RFC PATCH] cmdline: Hide "debug" from /proc/cmdline | From | Linus Torvalds <> |
| |
On Fri, Apr 4, 2014 at 11:21 AM, Andy Lutomirski <luto@amacapital.net> wrote: > > I'm using /dev/kmsg in virtme so that I can easily capture, with > timestamps, the ten or so log lines that it produces. It would be sad > if I had to worry about small ratelimits here.
So the _default_ rate limits (which is what my example patch used) are almost certainly not appropriate for /dev/kmsg.
It would be good to hear suggestions for what *would* be reasonable. Because it does sound like we'll have to add rate limiting.
Most users will never notice. The whole "writable /dev/kmsg" may go back to 2002, but there aren't _that_ many users, and pretty much all I've ever seen tend to write the occasional "I started up" messages or other very small notes. I had to write a test-script to trigger even the (very draconian) default ratelimits.
Linus
| |