lkml.org 
[lkml]   [2014]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/reboot] [PATCH] x86: Try the BIOS reboot method before the PCI reboot method

* Li, Aubrey <aubrey.li@linux.intel.com> wrote:

> <cc to adam>
>
> On 2014/4/4 16:00, Ingo Molnar wrote:
> >
> >>
> >> [PATCH] x86: Try the BIOS reboot method before the PCI reboot method
> >
> > So, JFYI, I have put this into x86/reboot to get it tested, but it's
> > not queued up for upstream yet until there's concensus.
> >
> > (Steve testing it wouldn't hurt either.)
> >
> > Thanks,
> >
> > Ingo
>
> The change is originated from the following bug:
> https://bugzilla.kernel.org/show_bug.cgi?id=70931
>
> The system will hang after BIOS or TRIPLE if it doesn't work, that's
> why I added CF9 before BIOS and TRIPLE.
>
> Adam may want to try this change to see if reboot works on his DELL
> Venue 8 Pro.
>
> I don't think there is enough justification to revert the patch.
> [...]

'Breaks a box' is more than enough justification to revert a patch...

You can try to fix boxes, but only if you can do it without breaking
others.

Thanks,

Ingo


\
 
 \ /
  Last update: 2014-04-04 20:21    [W:0.276 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site