Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [RFC 2/4] timer: don't migrate pinned timers | Date | Fri, 04 Apr 2014 08:15:19 -0700 |
| |
Viresh Kumar <viresh.kumar@linaro.org> writes:
> On 31 March 2014 21:26, Kevin Hilman <khilman@linaro.org> wrote: >> Viresh Kumar <viresh.kumar@linaro.org> writes: >>> + if (is_pinned) { >>> + pr_warn("%s: can't migrate pinned timer: %p, removing it\n", >>> + __func__, timer); >> >> printk message will be confusing: removing it from what? > > Hmm.. So, I am looking to do two modifications here. Just need inputs > if that would be the right thing to do: > > - do a WARN() here as these timers should have been already removed > - change print to: "can't migrate pinned timer %p, deactivating timer" > > Looks fine?
Yes.
| |