Messages in this thread | | | Date | Wed, 30 Apr 2014 22:51:45 +0300 | From | Vladimir Zapolskiy <> | Subject | Re: [PATCH 0/7 v8] crypto:s5p-sss: Add Device tree and Exynos support |
| |
Hi Naveen, Herbert,
On 04/30/14 15:14, Herbert Xu wrote: > On Wed, Apr 30, 2014 at 04:38:05PM +0530, Naveen Krishna Ch wrote: >> Hello All, >> >> On 28 April 2014 16:14, Naveen Krishna Chatradhi<ch.naveen@samsung.com> wrote: >>> SSS module on Exynos4210, Exynos5250 and Exynos5420 SoCs has added >>> features to the one on S5PV210. However with minor changes the s5p-sss.c >>> driver can be reused to support SSS modules on Exynos4 and 5 SoCs. >>> >>> This patch set >>> 1. Adds device tree support to the s5p-sss.c driver and Documentation >>> 2. Adds code to support SSS module on Exynos4 and 5 SoCs >>> 3. Adds variant struct to handle the differences in SSS modules >>> 4. Adds clk_prepare/clk_unprepare clocks to the s5p-sss.c driver >>> >>> Note: Compatible "exynos4210-secss" should work for Exynos4412 and >>> Exynos5260 (Exynos5260, for which ARCH code is under review) >>> I couldn't test on Exynos4412 and Exynos4210 boards, Should be able to >>> test with addition of DT node and clocks support. >>> >>> These patches are under review at >>> https://lkml.org/lkml/2014/2/17/124 >>> >>> Naveen Krishna Chatradhi (7): >>> crypto:s5p-sss: Use platform_get_irq() instead of _byname() >>> crypto:s5p-sss: Kconfig: Let Exynos SoCs select SSS driver >>> crypto:s5p-sss: Look for the next request in the queue >>> crypto:s5p-sss: Add device tree support >>> crypto:s5p-sss: Add support for SSS module on Exynos >>> crypto:s5p-sss: validate iv before memcpy >>> crypto:s5p-sss: Use clk_prepare/clk_unprepare >>> >>> .../devicetree/bindings/crypto/samsung-sss.txt | 35 +++++ >>> drivers/crypto/Kconfig | 6 +- >>> drivers/crypto/s5p-sss.c | 145 +++++++++++++++----- >>> 3 files changed, 150 insertions(+), 36 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/crypto/samsung-sss.txt >> >> Can we get this series merged in. >> Its has got reviewed and re-based several times and got acked by a >> couple of seniors. > > Do you want me to pick these series up? > > Cheers,
thank you for this changeset, in my opinion it is quite good. To all changes
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
-- With best wishes, Vladimir
| |