Messages in this thread | | | Date | Thu, 3 Apr 2014 17:37:01 +0200 | From | Jakub Kiciński <> | Subject | Re: [PATCH] rt2x00: BUG: remove double loop on REGISTER_BUSY_COUNT |
| |
On Thu, 3 Apr 2014 16:12:07 +0200, Richard Genoud wrote: > rt2x00usb_register_read_lock() calls rt2x00usb_vendor_req_buff_lock() > that calls rt2x00usb_vendor_request() which is already looping up to > REGISTER_BUSY_COUNT times. > > So this loop is not needed.
Not true. rt2x00usb_vendor_request() busy-waits for usb_control_msg() to succeed, rt2x00usb_register_read_lock() busy-waits for the register field itself to become 0.
Also, how would this be a BUG?
-- kuba
| |