lkml.org 
[lkml]   [2014]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 0/4] Provide netdev naming-policy via sysfs
From
From: David Herrmann <dh.herrmann@gmail.com>
Date: Wed, 2 Apr 2014 11:58:22 +0200

> This is v6 of the name_assign_type attribute for netdevs. Changes since v5 [1]:
> - Acked-by: Kay Sievers
> - rebased on net-next of today
>
> Aimed for 3.15, but feel free to delay for 3.16 if you want it in -next for some
> more time.

I'm fine with the basic idea, but the implementation needs work and
this will be deferred to 3.16 in any event.

We really need to specify the name allocation type at alloc_netdev()
time, I know that's more work but that's the only way you can be sure
you caught all such cases.

I know you missed the ISDN layer, where the name can come from the
user via an ioctl(). I'm sure there were several more.

You can even do something like make alloc_netdev_enumerated()
be a shorthand for alloc_netdev(size, name, NET_NAME_ENUM, ...)

Thanks.


\
 
 \ /
  Last update: 2014-04-03 20:21    [W:0.366 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site