lkml.org 
[lkml]   [2014]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 6/6 v2] staging: comedi: addi_apci_1564: remove use of devpriv->s_EeParameters
Date
On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote: 
> This driver no longer reads the eeprom to find the board specific data,
> all the necessary data is in the boardinfo. Use the boardinfo directly
> instead of passing through devpriv->s_EeParameters.
>
> Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> ---
> 2: Incorrect patch title fixed.
>
> Ian and Hartley,
>
> The auto_attach() function is starting to look much better now. My next patchset
> will be geared towards only allocating subdevices which are actually used.

Other than Ian's comment on patch 4/6 everything looks good to me.

For the series:
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>

BTW, for a patch series you should include a cover letter (PATCH 00/xx).

Regards,
Hartley


\
 
 \ /
  Last update: 2014-04-29 23:21    [W:0.149 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site