Messages in this thread | | | Date | Mon, 28 Apr 2014 14:14:39 -0400 | From | Steven Rostedt <> | Subject | Re: lockdep warning after recent cleanup in console code |
| |
On Mon, 28 Apr 2014 19:51:39 +0200 Jan Kara <jack@suse.cz> wrote:
> On Mon 28-04-14 13:43:31, Steven Rostedt wrote: > > Things have changed with regard to printk() in linux-next. Now it > > appears that lockdep is going haywire over it. I don't understand the > > exact reason for the lockdep_off() and lockdep_on() logic that is in > > printk(), but it obviously seems to be causing issues with the new > > changes. > > > > Care to take a look? > The obvious cause is that I moved lockdep_on() somewhat earlier in > vprintk_emit() so lockdep now covers more of printk code. And apparently > something is wrong there... >
Exactly, and I rather know *exactly* what is wrong before we just start throwing patches at the problem and hope it goes away. That's not how to solve a software bug.
-- Steve
| |