Messages in this thread | | | Date | Tue, 29 Apr 2014 12:56:54 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v3 2/3] perf record: Propagate exit status of a command line workload |
| |
On Thu, Apr 24, 2014 at 10:27:33PM +0900, Namhyung Kim wrote:
SNIP
> Reported-by: Stephane Eranian <eranian@google.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/builtin-record.c | 121 ++++++++++++++++++------------------------- > 1 file changed, 51 insertions(+), 70 deletions(-) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index eb524f91bffe..b1523d8a6191 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -152,26 +152,6 @@ static void sig_handler(int sig) > signr = sig;
looks like there's no use for 'signr' now.. could be removed
> } > > -static void record__sig_exit(int exit_status __maybe_unused, void *arg) > -{ > - struct record *rec = arg; > - int status; > - > - if (rec->evlist->workload.pid > 0) { > - if (!child_finished) > - kill(rec->evlist->workload.pid, SIGTERM); > - > - wait(&status); > - if (WIFSIGNALED(status)) > - psignal(WTERMSIG(status), rec->progname); > - } > - > - if (signr == -1 || signr == SIGUSR1) > - return; > - > - signal(signr, SIG_DFL);
I was wondering what was this one for and found:
perf_counter tools: Propagate signals properly commit f7b7c26e01e51fe46097e11f179dc71ce7950084 Author: Peter Zijlstra <a.p.zijlstra@chello.nl> Date: Wed Jun 10 15:55:59 2009 +0200
but I dont think we need to do that
thanks, jirka
| |