Messages in this thread | | | Date | Mon, 28 Apr 2014 22:24:55 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2] staging: silicom: Remove unused pointer in bypass_init_module() |
| |
On Mon, Apr 28, 2014 at 08:47:27PM +0200, Christian Engelmayer wrote: > Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused. Thus remove > it. With the last variable declaration gone, there is no more need for an own > block. Remove it and adapt the indenting accordingly. > > Signed-off-by: Christian Engelmayer <cengelma@gmx.at> > --- > v2: Added changes requested by Dan Carpenter: > > Dan pointed out that with the declaration gone, the indent block shall be > removed. This was intentionally left out in v1 in order to keep the > changeset more readable. However, according to the input, also with the > additional indenting change this still qualifies for one logical change. > > Compile tested and applies against v3.15-rc2 as well as branch staging-next > of tree git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
Great thanks. :) You only need to work against staging next and not v3.15-rc2 because this will go into v3.16.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |