lkml.org 
[lkml]   [2014]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] mfd: max14577: Fix IRQ handling after resume if this is not a wakeup source
From
Date
On pon, 2014-04-28 at 13:10 +0100, Lee Jones wrote:
> > During suspend the IRQ should be disabled even if this is not a wakeup
> > source. This is a proper way of fixing the IRQ handling issue during
> > resume (IRQ handler fails because I2C bus did not resume yet).
> >
> > When device is suspended and max14577 interrupt is signaled the irq chip
> > will try to handle it regardless of wakeup source. Device could be woken
> > up by different IRQ but still the IRQ handler will try to read the
> > registers over I2C bus and fail because I2C bus won't be ready yet:
> > max14577 2-0025: Failed to read IRQ status: -5
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > drivers/mfd/max14577.c | 29 +++++++++++++----------------
> > 1 file changed, 13 insertions(+), 16 deletions(-)
>
> It's pretty worrying that these two patches are so alike and they
> actually change different files. Is there any way we can unify more of
> the code?
>
> Patch applied, thanks.

This whole problem happens also on other MAXIM devices on our boards so
actually the real issue could sit in I2C bus controller or S3C PM
suspend/resume code. This is however the easiest fix for now...

Thanks for applying the patches.

Best regards,
Krzysztof



\
 
 \ /
  Last update: 2014-04-28 15:41    [W:0.078 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site