Messages in this thread Patch in this message | | | From | "Aneesh Kumar K.V" <> | Subject | [PATCH -V1 04/22] vfs: check for directory early | Date | Sun, 27 Apr 2014 21:44:35 +0530 |
| |
From: Andreas Gruenbacher <agruen@kernel.org>
Signed-off-by: Andreas Gruenbacher <agruen@kernel.org> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> --- fs/namei.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c index c7fee619691f..7d93d195f0e5 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3868,6 +3868,9 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de if (!inode) return -ENOENT; + if (S_ISDIR(inode->i_mode)) + return -EPERM; + error = may_create(dir, new_dentry); if (error) return error; @@ -3882,8 +3885,6 @@ int vfs_link(struct dentry *old_dentry, struct inode *dir, struct dentry *new_de return -EPERM; if (!dir->i_op->link) return -EPERM; - if (S_ISDIR(inode->i_mode)) - return -EPERM; error = security_inode_link(old_dentry, dir, new_dentry); if (error) -- 1.9.1
| |