lkml.org 
[lkml]   [2014]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm 0/6] memcg/kmem: cleanup naming and callflows
Please ignore this set - I found that something can be improved, will
send v2 soon. Sorry for the noise.

Thanks.

On Fri, Apr 25, 2014 at 04:33:06PM +0400, Vladimir Davydov wrote:
> Hi,
>
> In reply to "[PATCH RFC -mm v2 3/3] memcg, slab: simplify
> synchronization scheme" Johannes wrote:
>
> > I like this patch, but the API names are confusing. Could we fix up
> > that whole thing by any chance?
>
> (see https://lkml.org/lkml/2014/4/18/317)
>
> So this patch set is about cleaning up memcg/kmem naming.
>
> While preparing it I found that some of the ugly-named functions
> constituting interface between memcontrol.c and slab_common.c can be
> neatly got rid of w/o complicating the code. Quite the contrary, w/o
> them call-flows look much simpler, IMO. So the first four patches do not
> rename anything actually - they just rework call-flows in kmem cache
> creation/destruction and memcg_caches arrays relocations paths. Finally,
> patches 5 and 6 clean up the naming.
>
> Reviews are appreciated.
>
> Thanks,
>
> Vladimir Davydov (6):
> memcg: get rid of memcg_create_cache_name
> memcg: allocate memcg_caches array on first per memcg cache creation
> memcg: cleanup memcg_caches arrays relocation path
> memcg: get rid of memcg_{alloc,free}_cache_params
> memcg: cleanup kmem cache creation/destruction functions naming
> memcg: cleanup kmem_id-related naming
>
> include/linux/memcontrol.h | 40 +----
> include/linux/slab.h | 12 +-
> mm/memcontrol.c | 420 ++++++++++++++++++++------------------------
> mm/slab.c | 4 +-
> mm/slab.h | 24 ++-
> mm/slab_common.c | 127 ++++++++++----
> mm/slub.c | 10 +-
> 7 files changed, 320 insertions(+), 317 deletions(-)
>
> --
> 1.7.10.4
>


\
 
 \ /
  Last update: 2014-04-28 00:01    [W:0.055 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site