Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 1/2] perf tests: Factor out fake_setup_machine() | Date | Mon, 28 Apr 2014 08:59:42 +0900 |
| |
Hi Jiri,
On Fri, 25 Apr 2014 14:27:34 +0200, Jiri Olsa wrote: > On Fri, Apr 25, 2014 at 12:28:13PM +0900, Namhyung Kim wrote: >> The fake_setup_machine() is for setting up a environment for testing >> various hists operations. As it'll be used for other test cases it'd >> better factoring it out. > > looks like print_hists could be in hists_common.c as well.. > within another update ;-)
The difference is that one in hists_link.c is working on the input tree while one in hists_filter.c is working on the output tree.
> > nice! > > Acked-by: Jiri Olsa <jolsa@kernel.org> > > for patchset
Thanks for review! Namhyung
| |