lkml.org 
[lkml]   [2014]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] perf tests: Factor out fake_setup_machine()
Date
Hi Jiri,

On Fri, 25 Apr 2014 14:27:34 +0200, Jiri Olsa wrote:
> On Fri, Apr 25, 2014 at 12:28:13PM +0900, Namhyung Kim wrote:
>> The fake_setup_machine() is for setting up a environment for testing
>> various hists operations. As it'll be used for other test cases it'd
>> better factoring it out.
>
> looks like print_hists could be in hists_common.c as well..
> within another update ;-)

The difference is that one in hists_link.c is working on the input tree
while one in hists_filter.c is working on the output tree.

>
> nice!
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> for patchset

Thanks for review!
Namhyung


\
 
 \ /
  Last update: 2014-04-28 02:21    [W:0.063 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site