Messages in this thread | | | Date | Sat, 26 Apr 2014 11:42:37 +0200 | From | Paolo Bonzini <> | Subject | Re: [PATCH v2] KVM: x86: Check for host supported fields in shadow vmcs |
| |
Il 22/04/2014 21:31, Bandan Das ha scritto: > Paolo Bonzini <pbonzini@redhat.com> writes: > >> Il 22/04/2014 12:25, Bandan Das ha scritto: >>>>>>> + if (j < i) >>>>>>> + shadow_read_write_fields[j] = >>>>>>> + shadow_read_write_fields[i]; >>>>>>> + j++; >>>>> >>>>> ... you need to respin anyway because the j++ is wrong. It should be >>>>> inside the "if". If you prefer, you can put it in the lhs of the >>> j++ outside the "if" looks right to me. Can you please explain why >>> you think it shouldn't be that way ? >>> >> >> The way you wrote it, j will always be equal to i. > > Right, and that's what we want unless we come across an unsupported > field. We then overwrite the unsupported field with the next > field supported. j this way keeps track of the "real" length.
Doh, brain fart.
Paolo
| |