Messages in this thread |  | | Date | Fri, 25 Apr 2014 23:29:35 -0700 | | Subject | Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon | | From | Yinghai Lu <> |
| |
On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring <robherring2@gmail.com> wrote: > From: Rob Herring <robh@kernel.org> > > With the generic earlycon infrastructure in place, convert the 8250 > early console to use it. > > Signed-off-by: Rob Herring <robh@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.cz> > --- > drivers/tty/serial/8250/8250_early.c | 138 ++++------------------------------- > drivers/tty/serial/8250/Kconfig | 1 + > 2 files changed, 16 insertions(+), 123 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c > index c100d63..e83c9db 100644 > --- a/drivers/tty/serial/8250/8250_early.c > +++ b/drivers/tty/serial/8250/8250_early.c > @@ -35,18 +35,8 @@ ... > - > -int __init setup_early_serial8250_console(char *cmdline)
You removed global function, but still left declaration and calling...
arch/mips/mti-malta/malta-init.c: setup_early_serial8250_console(console_string); drivers/firmware/pcdp.c: return setup_early_serial8250_console(options); include/linux/serial_8250.h:extern int setup_early_serial8250_console(char *cmdline);
Yinghai
|  |