lkml.org 
[lkml]   [2014]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 05/10] ARM: EXYNOS: Remove regs-pmu.h header dependency from pm_domain
    HI Tomasz,


    On Sat, Apr 26, 2014 at 6:19 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote:
    > Hi,
    >
    >
    > On 25.04.2014 14:32, Pankaj Dubey wrote:
    >>
    >> From: Young-Gun Jang <yg1004.jang@samsung.com>
    >>
    >> Current "pm_domain.c" file uses "S5P_INT_LOCAL_PWR_EN" definition from
    >> "regs-pmu.h" and hence needs to include this header file. As there is
    >> no other user of "S5P_INT_LOCAL_PWR_EN" definition other than pm_domain,
    >> to remove "regs-pmu.h" header file dependency from "pm_domain.c" it's
    >> better we define this definition in "pm_domain.c" file itself and thus it
    >> will help in removing header file inclusion from "pm_domain.c".
    >>
    >> Signed-off-by: Young-Gun Jang <yg1004.jang@samsung.com>
    >> ---
    >> arch/arm/mach-exynos/pm_domains.c | 2 +-
    >> arch/arm/mach-exynos/regs-pmu.h | 1 -
    >> 2 files changed, 1 insertion(+), 2 deletions(-)
    >>
    >> diff --git a/arch/arm/mach-exynos/pm_domains.c
    >> b/arch/arm/mach-exynos/pm_domains.c
    >> index fe6570e..f676b0a 100644
    >> --- a/arch/arm/mach-exynos/pm_domains.c
    >> +++ b/arch/arm/mach-exynos/pm_domains.c
    >> @@ -22,7 +22,7 @@
    >> #include <linux/of_platform.h>
    >> #include <linux/sched.h>
    >>
    >> -#include "regs-pmu.h"
    >> +#define S5P_INT_LOCAL_PWR_EN 0x7
    >
    >
    > nit: You could indent the value a bit more in case of adding any new macros
    > in future. While at it, you could probably also drop the S5P_ prefix.
    >

    Thanks for review.
    Will take care of both suggestions.

    Thanks,
    Pankaj Dubey

    > With these fixed, feel free to add my
    >
    > Reviewed-by: Tomasz Figa <t.figa@samsung.com>
    >
    > Best regards,
    > Tomasz
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"
    > in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html


    \
     
     \ /
      Last update: 2014-04-26 06:01    [W:4.214 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site