This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Fri May 10 21:19:15 2024 Envelope-to: j@jasper.es Delivery-date: Sat, 26 Apr 2014 04:56:37 +0200 Received: from localhost ([127.0.0.1] helo=squeeze.vs19.net) by squeeze.vs19.net with esmtp (Exim 4.80) (envelope-from ) id 1Wdsn6-0004LR-Vm for j@jasper.es; Sat, 26 Apr 2014 04:56:37 +0200 Original-Recipient: rfc822;jasper@telfort.nl Received: from pop3.telfort.nl [213.75.3.52] by squeeze.vs19.net with POP3 (fetchmail-6.3.21) for (single-drop); Sat, 26 Apr 2014 04:56:36 +0200 (CEST) Received: from cpxmta-msg03.kpnxchange.com (10.94.114.24) by cpxmbs-msg01.support.local (8.6.060.31) id 533B4499011ED189 for jasper@telfort.nl; Sat, 26 Apr 2014 04:51:21 +0200 Received: from cpsmtpb-ews06.kpnxchange.com (213.75.39.9) by cpxmta-msg03.kpnxchange.com (8.6.060.14) id 533B6CA703263C67 for jasper@telfort.nl; Sat, 26 Apr 2014 04:51:21 +0200 Received: from cpsps-ews01.kpnxchange.com ([10.94.84.168]) by cpsmtpb-ews06.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Sat, 26 Apr 2014 04:51:21 +0200 Received: from vger.kernel.org ([209.132.180.67]) by cpsps-ews01.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Sat, 26 Apr 2014 04:51:20 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751326AbaDZCvE convert rfc822-to-quoted-printable (ORCPT ); Fri, 25 Apr 2014 22:51:04 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:24938 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbaDZCvA (ORCPT ); Fri, 25 Apr 2014 22:51:00 -0400 Received: from 172.24.2.119 (EHLO szxeml208-edg.china.huawei.com) ([172.24.2.119]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BUR70745; Sat, 26 Apr 2014 10:50:45 +0800 (CST) Received: from SZXEML453-HUB.china.huawei.com (10.82.67.196) by szxeml208-edg.china.huawei.com (172.24.2.57) with Microsoft SMTP Server (TLS) id 14.3.158.1; Sat, 26 Apr 2014 10:49:31 +0800 Received: from [127.0.0.1] (10.177.27.212) by SZXEML453-HUB.china.huawei.com (10.82.67.196) with Microsoft SMTP Server id 14.3.158.1; Sat, 26 Apr 2014 10:49:32 +0800 Message-Id: <535B1EB4.3050408@huawei.com> Date: Sat, 26 Apr 2014 10:49:24 +0800 From: Yijing Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 Mime-Version: 1.0 To: David Laight , Bjorn Helgaas Cc: Tony Luck , "linux-ia64@vger.kernel.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "sparclinux@vger.kernel.org" , Thoma Subject: Re: [PATCH 00/13] Refactor pci_is_brdige() to simplify code References: <1398417515-8740-1-git-send-email-wangyijing@huawei.com> <063D6719AE5E284EB5DD2968C1650D6D0F6FEEB0@AcuExch.aculab.com> In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D0F6FEEB0@AcuExch.aculab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Originating-IP: [10.177.27.212] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org X-OriginalArrivalTime: 26 Apr 2014 02:51:20.0924 (UTC) FILETIME=[675C81C0:01CF60FA] X-RcptDomain: telfort.nl On 2014/4/25 17:42, David Laight wrote: > From: Yijing Wang >> This patchset rename the current pci_is_bridge() to pci_has_subordin= ate(), >> and introduce a new pci_is_bridge() which determine pci bridge by ch= eck >> dev->hdr_type. The new one is more accurate. PCIe Spec define the pc= i >> device is a bridge by the dev->hdr_type =3D 0x01 || 0x02. >=20 > That is a dangerous rename and is likely to cause difficult to Hi David, I renamed pci_is_bridge() to pci_has_subordinate() because static inline bool pci_is_bridge(struct pci_dev *pci_dev) { return !!(pci_dev->subordinate); } which always check dev->subordinate. > identify bugs in any code you've missed. What are you referring to ? Thanks! Yijing. >=20 > David >=20 > =04=EF=BF=BD{.n=EF=BF=BD+=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD+%=EF=BF=BD=EF=BF=BDlzwm=EF=BF=BD=EF=BF=BDb=EF=BF=BD=EB= =A7=B2=EF=BF=BD=EF=BF=BDr=EF=BF=BD=EF=BF=BDzX=EF=BF=BD=EF=BF=BD=19=1E=EF= =BF=BDw=EF=BF=BD=EF=BF=BD{ay=EF=BF=BD=1D=CA=87=DA=99=EF=BF=BD,j=07=EF=BF= =BD=EF=BF=BDf=EF=BF=BD=EF=BF=BD=EF=BF=BDh=EF=BF=BD=EF=BF=BD=EF=BF=BDz=EF= =BF=BD=1E=EF=BF=BDw=EF=BF=BD=EF=BF=BD=EF=BF=BD=0C=EF=BF=BD=EF=BF=BD=EF=BF= =BDj:+v=EF=BF=BD=EF=BF=BD=EF=BF=BDw=EF=BF=BDj=EF=BF=BDm=EF=BF=BD=EF=BF=BD= =EF=BF=BD=EF=BF=BD=07=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BDzZ+=EF=BF=BD=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=DD=A2j"=EF=BF=BD=EF=BF=BD!=EF=BF=BDiO= =EF=BF=BD=EF=BF=BDz=EF=BF=BD=EF=BF=BDv=EF=BF=BD^=14=04=1A=EF=BF=BD=1Bm=EF= =BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=0Bn=C6=8A=EF=BF=BD=EF=BF=BDY&=EF=BF=BD >=20 --=20 Thanks! Yijing -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/