lkml.org 
[lkml]   [2014]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 1/1] hyperv: Properly handle checksum offload
From
Date
On Fri, 2014-04-25 at 17:43 -0700, Stephen Hemminger wrote:
> On Fri, 25 Apr 2014 11:45:14 -0700
> "K. Y. Srinivasan" <kys@microsoft.com> wrote:
>
> > @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct net_device *net)
> > csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)ppi +
> > ppi->ppi_offset);
> >
> > + ip_hdr(skb)->check = 0;
> > + csum_info->transmit.ip_header_checksum = 1;
> > +
> > if (net_trans_info & (INFO_IPV4 << 16))
> > csum_info->transmit.is_ipv4 = 1;
> > else
>
> Linux doesn't need or want IP checksum offload.
> It will not have any performance gain.


BTW, was this patch even tested with IPv6 packets ???




\
 
 \ /
  Last update: 2014-04-26 03:41    [W:0.067 / U:24.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site