Messages in this thread | | | Date | Fri, 25 Apr 2014 15:53:35 -0700 | Subject | Re: [GIT PULL] SCSI fixes for 3.15-rc3 | From | Linus Torvalds <> |
| |
On Fri, Apr 25, 2014 at 3:49 PM, David Rientjes <rientjes@google.com> wrote: > > Hmm, I see why this is needed because of the scsi_put_command(cmd), but I > think you need to do struct scsi_device *sdev = ACCESS_ONCE(cmd->device) > instead to prevent gcc from messing with the code generation.
No, if gcc were to move the access to 'cmd' to after the 'scsi_put_command(cmd)', that would be a major compiler bug.
Compilers can't just randomly move code around, guys.
Linus
| |