Messages in this thread | | | Subject | Re: [RFC PATCH] mfd: pm8x41: Naive function devices registration | From | "Ivan T. Ivanov" <> | Date | Fri, 25 Apr 2014 17:15:50 +0300 |
| |
On Fri, 2014-04-25 at 08:43 -0500, Rob Herring wrote: > On Fri, Apr 25, 2014 at 8:29 AM, Ivan T. Ivanov <iivanov@mm-sol.com> wrote: > > On Fri, 2014-04-25 at 08:00 -0500, Rob Herring wrote: > >> On Fri, Apr 25, 2014 at 7:32 AM, Ivan T. Ivanov <iivanov@mm-sol.com> wrote: > >> > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > >> > > >> > Currently functions that exist in both the controller at the > >> > same address offset can not be specified with the same names. > >> > > >> > Adding Unique Slave ID device address to prefix function > >> > device names fixes this. > >> > > >> > Function devices are SPMI devices, so register them on > >> > SPMI bus. > >> > > >> > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> > >> > --- > >> > drivers/mfd/pm8x41.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++---- > >> > >> No, this should be fixed in the core, not the driver. > > > > I think that at core level they are no issues. > > By core, I mean the device naming conventions used by the DT platform > device code. There is a problem and it should be handled. > > As I mentioned in the other thread, either we should not use the > address on non-translatable addresses like this or append the parent > address.
Ok, I see.
Regards, Ivan
| |