lkml.org 
[lkml]   [2014]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2] staging: comedi: addi_apci_1564: board does not have analog inputs
Date
On Friday, April 25, 2014 1:17 AM, Chase Southwood wrote:
> This board does not have analog inputs. Remove the subdevice init for
> them.
>
> Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
> Cc: Ian Abbott <abbotti@mev.co.uk>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>

Looks good.

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>

As Ian mentioned, after you have removed the init for all the non-existent
subdevices you should just get rid of them and only allocate the used ones.

Thanks,
Hartley



\
 
 \ /
  Last update: 2014-04-25 18:41    [W:0.076 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site