Messages in this thread | | | From | Hartley Sweeten <> | Subject | RE: [PATCH 1/2] staging: comedi: addi_apci_1564: board does not have analog inputs | Date | Fri, 25 Apr 2014 16:07:38 +0000 |
| |
On Friday, April 25, 2014 1:17 AM, Chase Southwood wrote: > This board does not have analog inputs. Remove the subdevice init for > them. > > Signed-off-by: Chase Southwood <chase.southwood@gmail.com> > Cc: Ian Abbott <abbotti@mev.co.uk> > Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Looks good.
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
As Ian mentioned, after you have removed the init for all the non-existent subdevices you should just get rid of them and only allocate the used ones.
Thanks, Hartley
| |