Messages in this thread | | | Date | Fri, 25 Apr 2014 10:36:48 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH v2 1/2] usb: ohci-exynos: Add facility to use phy provided by the generic phy framework |
| |
On Fri, 25 Apr 2014, Vivek Gautam wrote:
> Add support to consume phy provided by Generic phy framework. > Keeping the support for older usb-phy intact right now, in order > to prevent any functionality break in absence of relevant > device tree side change for ohci-exynos. > Once we move to new phy in the device nodes for ohci, we can > remove the support for older phys. > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > Cc: Jingoo Han <jg1.han@samsung.com> > Cc: Alan Stern <stern@rowland.harvard.edu>
> +static int exynos_ohci_phyg_on(struct phy *phy[]) > +{ > + int i; > + int ret = 0; > + > + for (i = 0; ret == 0 && i < PHY_NUMBER; i++) > + if (phy[i]) > + ret = phy_power_on(phy[i]); > + if (ret) > + for (i--; i >= 0; i--) > + if (phy[i]) > + phy_power_off(phy[i]); > + > + return ret; > +} > + > +static int exynos_ohci_phyg_off(struct phy *phy[]) > +{ > + int i; > + int ret = 0; > + > + for (i = 0; ret == 0 && i < PHY_NUMBER; i++) > + if (phy[i]) > + ret = phy_power_off(phy[i]); > + > + return ret; > +}
You probably shouldn't break out of this loop if ret is nonzero; you should continue to power off the remaining phys.
I'd be inclined to put these two routines directly into exynos_ohci_phy_enable() and exynos_ohci_phy_disable(), since they aren't used anywhere else.
> @@ -151,6 +253,7 @@ skip_phy: > > fail_add_hcd: > exynos_ohci_phy_disable(pdev); > + exynos_ohci_phyg_off(exynos_ohci->phy_g);
Why did you add this line? It doesn't do anything useful, because exynos_ohci_phy_disable() already calls exynos_ohci_phyg_off().
Alan Stern
| |