lkml.org 
[lkml]   [2014]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 05/20] usb: phy: msm: Migrate to Managed Device Resource allocation
From
On Thu, Apr 24, 2014 at 12:48 PM, Ivan T. Ivanov <iivanov@mm-sol.com> wrote:

> + motg->vddcx = devm_regulator_get(motg->phy.dev, "HSUSB_VDDCX");
> + if (IS_ERR(motg->vddcx)) {
> + dev_err(motg->phy.dev, "unable to get hsusb vddcx\n");
> + return PTR_ERR(motg->vddcx);
> + }
> +
> + motg->v3p3 = devm_regulator_get(motg->phy.dev, "HSUSB_3p3");
> + if (IS_ERR(motg->v3p3)) {
> + dev_err(motg->phy.dev, "unable to get hsusb 3p3\n");
> + return PTR_ERR(motg->v3p3);
> + }
> +
> + motg->v1p8 = devm_regulator_get(motg->phy.dev, "HSUSB_1p8");
> + if (IS_ERR(motg->v1p8)) {
> + dev_err(motg->phy.dev, "unable to get hsusb 1p8\n");
> + return PTR_ERR(motg->v1p8);
> + }

It seems that calling devm_regulator_bulk_get() here would simplify
the code here.


\
 
 \ /
  Last update: 2014-04-25 15:21    [W:0.621 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site