Messages in this thread | | | From | Hartley Sweeten <> | Subject | RE: [PATCH] staging: comedi: addi_apci_1564: separate from addi_common.c | Date | Thu, 24 Apr 2014 18:43:32 +0000 |
| |
On Thursday, April 24, 2014 12:19 AM, Chase Southwood wrote: > Using the addi-data "common" code in addi_apci_1564 introduces a lot of > bloat. By separating this driver off from addi_common.c, a lot of the > common code can be stripped out. This patch copies the code over from > addi_common.c, and removes the #include of the file. The auto_attach > function from the common code replaces the one that was previously in this > driver, though renamed to that it stays within the namespace associated > with this driver, and the detach function has been renamed for this reason > as well. > > Signed-off-by: Chase Southwood <chase.southwood@yahoo.com> > Cc: H Hartley Sweeten <hsweeten@visionengravers.com> > Cc: Ian Abbott <abbotti@mev.co.uk> > --- > Compile tested only.
Looks good.
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
| |