lkml.org 
[lkml]   [2014]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 1/1] x86/apic: add apic_irqs bitmap to identify irqs from apic

* Jason Chen <jason.cj.chen@intel.com> wrote:

> The function irq_force_complete_move() might handle irqs based on
> the non-apic irq_chip the way apic does, which has the structure
> irq_cfg as its chip_data.
> Wrong operations on non-apic irq_chip might make its chip_data changed
> and bring unexpected issues.
> Add apic_irqs bitmap to identify irqs from apic, and filter out all other
> irq_chips by checking this bitmap.

Please update the changelog to describe the current behavior, and how
it affects your platform. (I.e. how do users notice, if at all?)

Then describe why you think that behavior should be changed. ie:
what's the reason for this patch.

Only then describe the details of the change itself.

Thanks,

Ingo


\
 
 \ /
  Last update: 2014-04-24 09:41    [W:0.060 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site