Messages in this thread | | | Date | Thu, 24 Apr 2014 09:45:33 -0500 | From | Felipe Balbi <> | Subject | Re: [PATCHv3 3/9] extcon: max8997: Use devm_extcon_dev_allocate for extcon_dev |
| |
On Thu, Apr 24, 2014 at 09:34:51PM +0900, Chanwoo Choi wrote: > This patch use devm_extcon_dev_allocate() to simplify the memory control > of extcon device. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/extcon/extcon-max8997.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c > index 804a446..e2ee2f5 100644 > --- a/drivers/extcon/extcon-max8997.c > +++ b/drivers/extcon/extcon-max8997.c > @@ -699,8 +699,7 @@ static int max8997_muic_probe(struct platform_device *pdev) > } > > /* External connector */ > - info->edev = devm_kzalloc(&pdev->dev, sizeof(struct extcon_dev), > - GFP_KERNEL); > + info->edev = devm_extcon_dev_allocate(&pdev->dev, max8997_extcon_cable); > if (!info->edev) {
and here you never check for IS_ERR(info->evdev)
NAK
I suspect all following patches have the same defect.
-- balbi [unhandled content-type:application/pgp-signature] | |