lkml.org 
[lkml]   [2014]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL 0/4] perf/urgent fixes
On Thu, Apr 24, 2014 at 08:47:18AM +0200, Ingo Molnar wrote:

SNIP

>
> In any case, your patch fixes the bug. With VF=1 I get this output:
>
> Auto-detecting system features:
> ... dwarf: [ on ]
> ... glibc: [ on ]
> ... gtk2: [ on ]
> ... libaudit: [ on ]
> ... libbfd: [ on ]
> ... libelf: [ on ]
> ... libnuma: [ on ]
> ... libperl: [ on ]
> ... libpython: [ on ]
> ... libslang: [ on ]
> ... libunwind: [ on ]
> ... libdw-dwarf-unwind: [ on ]
> ... DWARF post unwind library: libunwind
> ... backtrace: [ on ]
> ... fortify-source: [ on ]
> ... gtk2-infobar: [ on ]
> ... libelf-getphdrnum: [ on ]
> ... libelf-mmap: [ on ]
> ... libpython-version: [ on ]
> ... on-exit: [ on ]
> ... stackprotector-all: [ on ]
> ... timerfd: [ on ]
> ... libunwind-debug-frame: [ OFF ]
> ... bionic: [ OFF ]
> ... liberty: [ OFF ]
> ... liberty-z: [ OFF ]
> ... cplus-demangle: [ OFF ]
>
> So yes, your obervation that it's the -liberty +libbfd combination is
> correct.
>
> Tested-by: Ingo Molnar <mingo@kernel.org>
>
> Btw., when reading the patch and the Makefile it was not obvious to me
> what 'VF' stood for. It's pretty clear what CORE_FEATURE_TESTS and

VF - Verbose for Features ;-)

> LIB_FEATURE_TESTS means, but there's no comment for VF_FEATURE_TESTS
> and the name is not self-explanatory.
>
> I figured it out from a bit of git log digging that its purpose is to
> generate the 'verbose feature check' output. But the variable is not
> commented and the features it lists overlaps CORE_FEATURE_TESTS and
> LIB_FEATURE_TESTS - so perhaps a bit more explanation (and possible
> reduction in duplication) might be useful?
>
> If it said ALL_FEATURE_TESTS and used $(CORE_FEATURE_TESTS) as a
> baseline then that would be self-explanatory.
>
> (In a separate patch from the fix.)

ok, will add something along those lines ;-)

thanks,
jirka


\
 
 \ /
  Last update: 2014-04-24 14:21    [W:0.109 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site