lkml.org 
[lkml]   [2014]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC 0/4] Migrate timers away from cpuset on setting cpuset.quiesce
    From
    On 24 April 2014 14:54, Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp> wrote:
    > Why didn't you just apply the patch on top of your tree so that the
    > information included in the git commit (e.g: my name and mail) remains?
    >
    > This part:
    >
    > cpuset: quiesce: change irq disable/enable by irq save/restore
    >
    > The function __migrate_timers can be called under interrupt context
    > or thread context depending on the core where the system call was
    > executed. In case it executes under interrupt context, it
    > seems a bad idea to leave interrupts enabled after migrating the
    > timers. In fact, this caused kernel errors on the ARM architecture and
    > on the x86_64 architecture with the 3.10 kernel (backported version
    > of the cpuset-quiesce patch).
    >
    > Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
    > Signed-off-by: Yoshitake Kobayashi <yoshitake.kobayashi@toshiba.co.jp>

    That's what I told you earlier when I said this:

    > I can't keep it as a separate patch and so would be required to merge
    > it into my original patch..

    And the reason being: "No patch is supposed to break things, otherwise
    git bisect wouldn't work smoothly".. And so git bisect would complain
    this issue after my patch and so I have to merge the fixes you gave into
    the original patch as its not yet merged.


    \
     
     \ /
      Last update: 2014-04-24 12:21    [W:4.451 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site