lkml.org 
[lkml]   [2014]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/13] tty: serial: omap: fix Sparse warnings
    Date
    Fix the following Sparse warnings:

    drivers/tty/serial/omap-serial.c:1418:49: warning: incorrect \
    type in argument 2 (different address spaces)
    drivers/tty/serial/omap-serial.c:1418:49: expected void const \
    [noderef] <asn:1>*from
    drivers/tty/serial/omap-serial.c:1418:49: got struct serial_rs485 \
    *<noident>
    drivers/tty/serial/omap-serial.c:1426:35: warning: incorrect \
    type in argument 1 (different address spaces)
    drivers/tty/serial/omap-serial.c:1426:35: expected void [noderef] \
    <asn:1>*to
    drivers/tty/serial/omap-serial.c:1426:35: got struct serial_rs485 \
    *<noident>

    Reported-by: Nishanth Menon <nm@ti.com>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
    ---
    drivers/tty/serial/omap-serial.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
    index ab22dab..d017cec 100644
    --- a/drivers/tty/serial/omap-serial.c
    +++ b/drivers/tty/serial/omap-serial.c
    @@ -1398,7 +1398,7 @@ serial_omap_ioctl(struct uart_port *port, unsigned int cmd, unsigned long arg)

    switch (cmd) {
    case TIOCSRS485:
    - if (copy_from_user(&rs485conf, (struct serial_rs485 *) arg,
    + if (copy_from_user(&rs485conf, (void __user *) arg,
    sizeof(rs485conf)))
    return -EFAULT;

    @@ -1406,7 +1406,7 @@ serial_omap_ioctl(struct uart_port *port, unsigned int cmd, unsigned long arg)
    break;

    case TIOCGRS485:
    - if (copy_to_user((struct serial_rs485 *) arg,
    + if (copy_to_user((void __user *) arg,
    &(to_uart_omap_port(port)->rs485),
    sizeof(rs485conf)))
    return -EFAULT;
    --
    1.9.2.459.g68773ac


    \
     
     \ /
      Last update: 2014-04-28 00:01    [W:2.060 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site