lkml.org 
[lkml]   [2014]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 01/19] usb: phy: msm: Make driver selectable on ARCH_QCOM
On Wed, Apr 23, 2014 at 11:48:29AM +0300, Ivan T. Ivanov wrote:
> On Tue, 2014-04-22 at 10:24 -0500, Felipe Balbi wrote:
> > On Tue, Apr 22, 2014 at 06:16:35PM +0300, Ivan T. Ivanov wrote:
> > >
> > > Hi,
> > >
> > > On Tue, 2014-04-22 at 09:57 -0500, Felipe Balbi wrote:
> > > > On Tue, Apr 22, 2014 at 12:20:20PM +0300, Ivan T. Ivanov wrote:
> > > > > From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> > > > >
> > > > > Controller could be found on APQ and MSM platforms,
> > > > > make configuration description more generic.
> > > > >
> > > > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
> > > > > ---
> > > > > drivers/usb/phy/Kconfig | 6 +++---
> > > > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> > > > > index 416e0c8..0c668a3 100644
> > > > > --- a/drivers/usb/phy/Kconfig
> > > > > +++ b/drivers/usb/phy/Kconfig
> > > > > @@ -171,11 +171,11 @@ config USB_ISP1301
> > > > > module will be called phy-isp1301.
> > > > >
> > > > > config USB_MSM_OTG
> > > > > - tristate "OTG support for Qualcomm on-chip USB controller"
> > > > > - depends on (USB || USB_GADGET) && ARCH_MSM
> > > > > + tristate "Qualcomm on-chip USB OTG controller support"
> > > > > + depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM)
> > > >
> > > > I would actually drop USB || USB_GADGET dependency here just make it
> > > > easier to enable the driver on Kconfig, other you have to enable
> > > > USB_SUPPORT, then enable USB, go back one menu level, go down to PHY
> > > > menu, and choose this driver.
> > > >
> > >
> > > Because phy directory already depends on USB_SUPPORT?
> >
> > right
>
> Build fails if USB and USB_GADGET are not selected.
> of_usb_get_dr_mode is part of USB_COMMON.
>
> ...
>
> if USB_SUPPORT
>
> config USB_COMMON
> tristate
> default y
> depends on USB || USB_GADGET
>
> ...
>
> of_usb_get_dr_mode() is no part of this patch, but should I remove
> dependency here and add it several patches later?

I guess we can keep it as is and I'll sort that out globaly later, I can
see a few other PHYs have some "weirdness" in their dependencies

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-04-28 00:01    [W:0.060 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site