lkml.org 
[lkml]   [2014]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/13] tty: serial: omap: switch over to platform_get_resource
    On Wed, Apr 23, 2014 at 12:27:59PM -0300, Fabio Estevam wrote:
    > On Wed, Apr 23, 2014 at 11:58 AM, Felipe Balbi <balbi@ti.com> wrote:
    >
    > > @@ -1658,12 +1657,9 @@ static int serial_omap_probe(struct platform_device *pdev)
    > > omap_up_info = of_get_uart_port_info(&pdev->dev);
    > > pdev->dev.platform_data = omap_up_info;
    > > } else {
    > > - irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
    > > - if (!irq) {
    > > - dev_err(&pdev->dev, "no irq resource?\n");
    > > - return -ENODEV;
    > > - }
    > > - uartirq = irq->start;
    > > + uartirq = platform_get_irq(pdev, 0);
    > > + if (uartirq < 0)
    > > + return -EPROBE_DEFER;
    >
    >
    > Maybe you could just do a 'return uartirq' here instead.

    I don't mind either way, I'm only returning -EPROBE_DEFER because that's
    what the other branch of this conditional returns. Tony, what do you
    prefer ?

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-04-26 23:01    [W:7.598 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site