Messages in this thread | | | Date | Wed, 23 Apr 2014 16:19:32 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v3] mfd: syscon: Support early initialization |
| |
On Wed, Apr 23, 2014 at 03:04:28PM +0200, Michal Simek wrote:
> In early_syscon_probe np->data contains pointer to struct syscon which > stores base, regmap and res - driver private data for system controller. > (init in early_syscon_probe) > This is the way I am aware of how to share driver private data without pdev. > Maybe there is better way how to do it that's why please let me know > if you are aware about it.
The main issue I'm seeing is that the fact that the pointer in the node is being used without a reference being held; I'd expect something to explicitly own the reference. Either hold the reference somewhere and hand it off between the various stages or free the syscon object and allocate a new one each time it's used prior to the device being instantiated. [unhandled content-type:application/pgp-signature] | |