lkml.org 
[lkml]   [2014]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] mfd: syscon: Support early initialization
On Wed, Apr 23, 2014 at 03:04:28PM +0200, Michal Simek wrote:

> In early_syscon_probe np->data contains pointer to struct syscon which
> stores base, regmap and res - driver private data for system controller.
> (init in early_syscon_probe)
> This is the way I am aware of how to share driver private data without pdev.
> Maybe there is better way how to do it that's why please let me know
> if you are aware about it.

The main issue I'm seeing is that the fact that the pointer in the node
is being used without a reference being held; I'd expect something to
explicitly own the reference. Either hold the reference somewhere and
hand it off between the various stages or free the syscon object and
allocate a new one each time it's used prior to the device being
instantiated.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-04-24 08:01    [W:0.069 / U:1.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site