Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] modpost: Fix ressource leak in read_dump() | Date | Tue, 22 Apr 2014 16:56:41 +0930 |
| |
Michal Marek <mmarek@suse.cz> writes:
> On 2014-04-06 02:05, Andi Kleen wrote: >> On Sun, Apr 06, 2014 at 12:36:49AM +0200, Christian Engelmayer wrote: >>> Function read_dump() memory maps the input via grab_file(), but fails to call >>> the corresponding unmap function. Add the missing call to release_file(). >>> Detected by Coverity: CID 1192419 >> >> It doesn't matter at all. All memory is freed on exit() in this program. > > The leak can disturb in valgrind output.
Yeah. If release_file() didn't exist at all, I'd agree with Andi. As it is, I've queued the patch (with typo in title fixed).
Thanks! Rusty.
| |