Messages in this thread | | | Date | Tue, 22 Apr 2014 16:18:09 +0100 | From | Will Deacon <> | Subject | Re: [PATCH 18/18] asm-generic: io: define relaxed accessor macros unconditionally |
| |
Hi Michal,
On Tue, Apr 22, 2014 at 03:09:46PM +0100, Michal Simek wrote: > On 04/17/2014 03:44 PM, Will Deacon wrote: > > Now that no architectures using asm-generic/io.h define their own relaxed > > accessors, the dummy definitions can be used unconditionally. > > > > Cc: Arnd Bergmann <arnd@arndb.de> > > Signed-off-by: Will Deacon <will.deacon@arm.com> > > --- > > include/asm-generic/io.h | 18 ------------------ > > 1 file changed, 18 deletions(-) > > Do we need this? I think there could be a need to overwrite them. > Currently we are just lucky that architecture which uses asm-generic/io.h > don't need to overwrite it. > But I expect that all archs should use asm-generic/io.h to clean > architecture io.h exactly I have done it for Microblaze.
I'm open to keeping the conditional definitions, but it introduces a discrepancy with the non-relaxed versions, which are defined unconditionally (although the underlying __raw_* accessors can be overridden).
Will
| |