Messages in this thread | | | Date | Tue, 22 Apr 2014 14:52:10 +0200 | Subject | Re: [PATCH RESEND 2/5] pinctrl: berlin: add a pinctrl driver for Marvell Berlin SoCs | From | Linus Walleij <> |
| |
On Fri, Apr 11, 2014 at 3:35 PM, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote: > On 04/11/2014 02:37 PM, Antoine Ténart wrote: >> On Fri, Apr 11, 2014 at 11:03:48AM +0200, Sebastian Hesselbarth wrote: >>> On 04/10/2014 03:07 PM, Antoine Ténart wrote:
>>> Having said that, the above assumes that each function is unique >>> but IIRC the idea of the function table was to group pins/groups >>> with the same function, e.g. function "gpio", groups 1,7,25,... >> >> Most of the functions you can use on the Berlin they will be unique and >> would >> only be used in one group, except for the 'gpio' one. > > Yeah, I had a similar discussion about it back then for mvebu. IIRC, the > correct answer is: Have a list of functions with groups assigned to it > no matter if there is only one group per function (or 40 per function as > it will be for gpio). > > Maybe Linus can give an update on how to deal with it?
Have you considered implementing pinmux_ops .gpio_request_enable(), .gpio_set_direction() and .gpio_disable_free() instead of defining groups for each and every GPIO?
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |