lkml.org 
[lkml]   [2014]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1] dma: imx-sdma: add support for sdma memory copy
    On Tue, Apr 22, 2014 at 10:28:05AM +0000, Shevchenko, Andriy wrote:
    > On Fri, 2014-04-18 at 17:41 +0800, Robin Gong wrote:
    > > On Thu, Apr 17, 2014 at 10:24:50AM +0000, Shevchenko, Andriy wrote:
    > > > On Thu, 2014-04-17 at 18:01 +0800, Robin Gong wrote:
    >
    > []
    >
    > > > > + dev_dbg(sdma->dev, "memcpy: %x->%x, len=%d, channel=%d.\n",
    > > >
    > > > %pad for dma_addr_t variables.
    > > >
    > > Yes, %x here is not proper, will be %#llx here to align with others similar
    > > code in this file.
    >
    > Why %#llx? You don't need the specific casting since kernel has special
    > specifiers for phys_addr_t and dma_addr_t and their derivatives (see
    > Documentation/printk-formats.txt)
    >
    I think both are ok, why I choose %llx is only for align the code style, you
    can find the same code in sdma_prep_dma_cyclic function. below description also
    copy from Documentation/printk-formats.txt:


    If <type> is dependent on a config option for its size (e.g., sector_t,
    blkcnt_t, phys_addr_t, resource_size_t) or is architecture-dependent
    for its size (e.g., tcflag_t), use a format specifier of its largest
    possible type and explicitly cast to it. Example:

    printk("test: sector number/total blocks: %llu/%llu\n",
    (unsigned long long)sector, (unsigned long long)blockcount);
    > > > > + dev_dbg(sdma->dev, "entry %d: count: %d dma: 0x%08x %s%s\n",
    > > > > + i, count, sg_src->dma_address,
    > > >
    > > > %pad for dma_addr_t.
    > > >
    > > Accept the idea, same as the above.
    >
    > Same as above.
    >
    > --
    > Andy Shevchenko <andriy.shevchenko@intel.com>
    > Intel Finland Oy
    > ---------------------------------------------------------------------
    > Intel Finland Oy
    > Registered Address: PL 281, 00181 Helsinki
    > Business Identity Code: 0357606 - 4
    > Domiciled in Helsinki
    >
    > This e-mail and any attachments may contain confidential material for
    > the sole use of the intended recipient(s). Any review or distribution
    > by others is strictly prohibited. If you are not the intended
    > recipient, please contact the sender and delete all copies.


    \
     
     \ /
      Last update: 2014-04-22 13:41    [W:5.448 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site