lkml.org 
[lkml]   [2014]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/5] ARM: dts: Device tree for AXM55xx.
From
On Tue, Apr 15, 2014 at 2:45 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 15 April 2014 14:06:11 Anders Berg wrote:

>> + serial0: uart@2010080000 {
>> + compatible = "arm,pl011", "arm,primecell";
>> + reg = <0x20 0x10080000 0 0x1000>;
>> + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clk_per>, <&clk_per>;
>> + clock-names = "uartclk", "apb_pclk";
>> + status = "disabled";
>> + };
>
> "uartclk" is not a valid string for pl011, as per binding:
>
> | - clocks: When present, must refer to exactly one clock named
> | "apb_pclk"
>
> I do see that a lot of platforms do the same thing you have here, not
> sure who is wrong.

OK the PL011 is tricksier. It has two clocks, the APB clock driving
the logic and another clock input that is divided down to generate
the external data clock (baud rate).

The bus will do:
pcdev->pclk = clk_get(&pcdev->dev, "apb_pclk");

The driver will do:
uap->clk = devm_clk_get(&dev->dev, NULL);

So the driver relies on the anonymous clock being "first"
in a clock retrieveal operation, and it's a bit fragile indeed.
That leads to that either you give this clock a sensible
name or you list the empty string, as you have to have
clock-names there to name the last entry so the bus can
retrieve it.

This clock is *indeed* named "UARTCLK" (capital letters)
in the TRM for PL011. So I think this is perfectly reasonable.

The situation is the same as with the PL022 SPI driver we have
discussed before, it also retrieves the anonymous clock but we
consistently named it "SSPCLK" in commits:
dfc9832ca3f7a10d573e29e46d6ba03a54fbe580
80fbe30f63c9ba2ab62eb2c1f7ef607ce0721a95

As everyone else was using that. And it was the name from
the TRM.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2014-04-23 05:41    [W:0.126 / U:16.268 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site