Messages in this thread | | | Date | Mon, 21 Apr 2014 12:15:44 -0500 | From | Larry Finger <> | Subject | Re: [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon |
| |
On 04/21/2014 11:38 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > static code analysis from cppcheck reports: > > [drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]: > (error) Uninitialized variable: packet_beacon > > packet_beacon is not initialized and hence packet_beacon > contains garbage from the stack, so set it to false. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
This change should have a "Cc: Stable <stable@vger.kernel.org> [3.10+] notation.
Other than that, Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
John: Is it possible for you to add stable, or do you want Colin to resubmit.
Larry
> > diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c > index 06ef47c..5b4c225 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c > +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c > @@ -293,7 +293,7 @@ static void _rtl88ee_translate_rx_signal_stuff(struct ieee80211_hw *hw, > u8 *psaddr; > __le16 fc; > u16 type, ufc; > - bool match_bssid, packet_toself, packet_beacon, addr; > + bool match_bssid, packet_toself, packet_beacon = false, addr; > > tmp_buf = skb->data + pstatus->rx_drvinfo_size + pstatus->rx_bufshift; > >
| |