Messages in this thread | | | Date | Mon, 21 Apr 2014 17:30:58 +0100 | From | Al Viro <> | Subject | Re: [RFC 2/2] fs,proc: Respect FMODE_WRITE when opening /proc/pid/fd/N |
| |
On Mon, Apr 21, 2014 at 09:22:48AM -0700, Andy Lutomirski wrote:
> +static int proc_may_follow(struct nameidata *nd, struct file *f) > +{ > + if (!nd) > + return 0; /* This is readlink, */ > + > + if ((nd->flags & LOOKUP_WRITE) && !(f->f_mode & FMODE_WRITE)) > + return -EACCES; > + > + return 0; > +}
And this is just plain wrong. WTF are you making the traversal of symlink in the middle of pathname dependent on the open flags?
NAK.
| |